-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish status messages (read in Fronts tool) #51
Conversation
a52cb9f
to
e48f887
Compare
31fc6ee
to
f39b5c1
Compare
f39b5c1
to
d30cc92
Compare
Currently failing to post messages to the SNS topic with
|
dc89d40
to
055bd77
Compare
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
9b7716f
to
16753c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some trouble deploying to CODE, but other than that this looks good to me! One comment about the indentation in a file, but that’s pretty unimportant – can definitely merge without addressing that.
The trouble deploying to CODE is more troubling: it looks like it’s trying to recreate a dead-letter queue for some reason?
d927337
to
58e63fb
Compare
Deployed now – recommend testing with an empty issue for now, e.g. https://fronts.code.dev-gutools.co.uk/v2/issues/10415d60-87c0-4f26-a6fa-9bcc5aa246aa, as Chef validation is waiting on guardian/facia-tool#1612. (I've tested, it looks good!) |
What does this change?
Publishes status messages on curation deploy succeed or failure to an SNS topic, which is read in the Fronts tool.
How to test
Tested in CODE: